[ENH] Enable background jobs for custom data handles (#7)#47
Conversation
|
Greetings @Shashankss1205, The 2 remaining CI failures are pre-existing on main as well.
Let me know if anything needs to be changed. |
|
Please pull the latest commit and then make this PR, also try to ensure the ruff tests pass. |
|
Got it, I’ll pull the latest changes and make sure the ruff tests pass before opening the PR. Thanks! |
815aa86 to
dfa35bc
Compare
|
Greetings @Shashankss1205, |
dfa35bc to
b3c3b48
Compare
|
Greetings @Shashankss1205, Rebased on the latest main and resolved the merge conflicts. |
|
Hey @Abhishek9639 the tests are failing and am still merging this. This is happening only because the tests are wrong. We will be rewriting most of the tests again. |
Got it, thanks for the clarification. That makes sense. |
Reference Issues/PRs
Fixes #7
What does this implement/fix? Explain your changes.
Updated
fit_predict_asyncto support custom data handles alongside demo datasets. Previously it only worked with built-in datasets like "airline" now users can pass adata_handlefromload_data_sourceto train models on their own data in the background.Changes:
data_handleparameter tofit_predict_async_toolinfit_predict.py.Executor.fit_predict_asyncto branch between demo dataset and custom data handle.datasetordata_handlemust be provided.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
fit_predict_async_toolmaking sure the either/or check is solid.Executor.fit_predict_asyncthedata_handlepath vs thedatasetpath.Any other comments?
Backward compatible existing calls with
dataset=still work exactly as before.PR checklist
For all contributions
For new estimators